Switch to using directly piboot instead of u-boot #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use piboot directly instead of running u-boot as second stage bootloader, now that is supported by snapd.
jawn-smith
reviewed
Mar 18, 2022
| touch $(DESTDIR)/piboot.conf | ||
| cp -a configs/core/config.txt.$(ARCH) $(DESTDIR)/config.txt | ||
| sed -i 's/^kernel=.*/kernel=kernel.img/' $(DESTDIR)/config.txt | ||
| printf '\ninitramfs initrd.img followkernel\nos_prefix=\n' >> $(DESTDIR)/config.txt |
There was a problem hiding this comment.
This appears to leave "os_prefix=" without a value. I assume that needs an update?
There was a problem hiding this comment.
config.txt will be modified in the snap prepare-image step with the right os_prefix - note that the value cannot be known before that as initially it points to the install system.
|
Given everything else has landed now, i guess this can be merged into regular branch now. |
|
Closing this in favor of #87. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use piboot directly instead of running u-boot as second stage
bootloader, now that is supported by snapd.
Opening as a draft, just as reference for the moment. We might maybe want this a separate branch in this repository (
22-arm64-piboot?)These other PRs would be needed:
canonical/snapd#11068
canonical/ubuntu-image#40
canonical/core-base#30
canonical/core-initrd#85